Release ctrlaltbot 1.1.3 - #5
Merged
Merged
Conversation
Fix /ask and /docs search failing with "didn't respond in time" when a docs site's home page is among the results. Its empty slug produced an empty select-menu option value, which makes Discord reject the reply. /docs page now searches for text that isn't a page slug instead of replying "Page not found".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/askand/docs searchfailing with "didn't respond in time" when a docs site's home page is among the results: its empty slug produced an empty select-menu option value, and Discord rejects the whole reply for that. The home page is now left out of the menu./docs pagewith text that isn't a slug (e.g.tiktok) now searches for it instead of replying "Page not found".Verified against live docs.casterlabs.co results for three queries; covered by a new test.